mirror of
https://github.com/sudosylabs/vnidrop.git
synced 2026-08-05 10:29:58 +02:00
cdricms
4730554c2c
Replace the free-form InvitationError.message(String) case with semantic
cases mapped to L10n keys at the UI boundary (Error.uiText), so user-facing
error text is localized instead of substring-matched from English blobs.
.raw(String) remains only for genuinely dynamic system/core messages.
Localize the CoreNFC alertMessage prompts via existing L10n keys, and add
SwiftLint rules (raw_alert_message, raw_invitation_error) to catch raw
alert strings and literal .raw("…") errors going forward.
50 lines
2.0 KiB
YAML
50 lines
2.0 KiB
YAML
# Focused lint for the native app: enforce the typed-resources convention only
|
|
# (no default style rules, so this stays signal, not noise).
|
|
only_rules:
|
|
- custom_rules
|
|
|
|
included:
|
|
- VniDrop
|
|
|
|
excluded:
|
|
- VniDrop/Generated
|
|
|
|
custom_rules:
|
|
raw_localized_string:
|
|
name: "Raw localized key"
|
|
regex: 'String\(localized:\s*"'
|
|
message: "Use a typed L10n.* accessor, not a raw key string."
|
|
severity: warning
|
|
raw_localized_string_key:
|
|
name: "Raw LocalizedStringKey"
|
|
regex: 'LocalizedStringKey\("'
|
|
message: "Use a typed L10n.* accessor instead of a raw key."
|
|
severity: warning
|
|
raw_sf_symbol:
|
|
name: "Raw SF Symbol"
|
|
regex: 'system(Name|Image):\s*"'
|
|
message: "Use SFSafeSymbols: Image(systemSymbol:) or systemSymbol:."
|
|
severity: warning
|
|
raw_swiftui_string_literal:
|
|
name: "Raw SwiftUI string"
|
|
# A non-empty string literal as the leading arg of a view initializer is an
|
|
# implicit LocalizedStringKey. Empty labels (e.g. Picker("", …)) are allowed.
|
|
regex: '\b(Text|Label|Button|Toggle|Link|NavigationLink|Section|Picker|Stepper|TextField|SecureField|DisclosureGroup|Menu|GroupBox)\("[^"]'
|
|
message: "Pass a typed L10n.* accessor (or Text(verbatim:)), not a raw string literal."
|
|
severity: warning
|
|
raw_alert_message:
|
|
name: "Raw NFC/alert message"
|
|
# User-facing UIKit/CoreNFC prompts (e.g. NFCReaderSession.alertMessage) must
|
|
# be localized, not hardcoded English.
|
|
regex: '\balertMessage\s*=\s*"'
|
|
message: "Assign a localized value (String(localized: L10n.*)), not a raw string literal."
|
|
severity: warning
|
|
raw_invitation_error:
|
|
name: "Raw InvitationError literal"
|
|
# InvitationError.raw is the escape hatch for genuinely dynamic system/core
|
|
# messages; a string literal here is a loose user-facing string that belongs
|
|
# in a typed InvitationError case mapped to L10n in UserFacingError.swift.
|
|
regex: 'InvitationError\.raw\("'
|
|
message: "Add a typed InvitationError case + L10n mapping instead of a literal .raw(\"…\")."
|
|
severity: warning
|