mirror of
https://github.com/sudosylabs/vnidrop.git
synced 2026-08-05 10:29:58 +02:00
cdricms
6180cb95ce
Confirming a transfer/history deletion flashed the same confirmation alert a second time before it went away. The destructive button runs confirmDelete synchronously (setting isDeleting = true), while the alert's isPresented dismiss binding fires asynchronously and then no-ops because its `if !isDeleting` guard is already false — leaving the open flag set, so macOS re-reads the binding as true and re-presents the alert until the async delete finally clears it. Close the confirmation flag synchronously in confirmDeleteTransfer / confirmHistoryDelete so there's no window for re-presentation. Tests assert the flag clears immediately, before the async delete completes.
62 lines
1.9 KiB
Swift
62 lines
1.9 KiB
Swift
import XCTest
|
|
@testable import VniDrop
|
|
|
|
/// Ports the send-side state-machine assertions from `feature/ViewModelsTest.kt`.
|
|
@MainActor
|
|
final class SendModelTests: XCTestCase {
|
|
|
|
private func makeModel(_ core: FakeCoreGateway) -> SendModel {
|
|
SendModel(
|
|
repository: core,
|
|
fileSystemService: FakeFileSystemService(),
|
|
preferences: Fixtures.preferences(),
|
|
filePreviewRepository: FilePreviewRepository(appDataDir: NSTemporaryDirectory() + UUID().uuidString),
|
|
messages: UiMessageController()
|
|
)
|
|
}
|
|
|
|
func testOpenAndCloseTransferDetails() {
|
|
let model = makeModel(FakeCoreGateway())
|
|
model.openTransfer(3)
|
|
XCTAssertEqual(model.state.selectedTransferId, 3)
|
|
model.closeTransferDetails()
|
|
XCTAssertNil(model.state.selectedTransferId)
|
|
}
|
|
|
|
func testDeleteTransferConfirmationFlow() async {
|
|
let core = FakeCoreGateway()
|
|
let model = makeModel(core)
|
|
model.openTransfer(3)
|
|
|
|
model.requestDeleteTransfer()
|
|
XCTAssertTrue(model.state.isDeleteConfirmationOpen)
|
|
|
|
model.confirmDeleteTransfer()
|
|
// Must close immediately (not after the async delete) so the alert can't
|
|
// re-present on macOS.
|
|
XCTAssertFalse(model.state.isDeleteConfirmationOpen)
|
|
await waitUntil { core.deletedTransfers.contains(3) }
|
|
XCTAssertEqual(core.deletedTransfers, [3])
|
|
XCTAssertNil(model.state.selectedTransferId)
|
|
XCTAssertFalse(model.state.isDeleteConfirmationOpen)
|
|
}
|
|
|
|
func testStopSharingCancelsTheTransfer() async {
|
|
let core = FakeCoreGateway()
|
|
let model = makeModel(core)
|
|
model.stopSharing(transferId: 4)
|
|
await waitUntil { core.cancelledTransfers.contains(4) }
|
|
XCTAssertEqual(core.cancelledTransfers, [4])
|
|
}
|
|
|
|
func testCancelReceiverRefusesTheRequest() async {
|
|
let core = FakeCoreGateway()
|
|
let model = makeModel(core)
|
|
model.openTransfer(1)
|
|
model.cancelReceiver(requestId: "req-1")
|
|
await waitUntil { core.responses.contains { $0.id == "req-1" } }
|
|
let response = core.responses.first { $0.id == "req-1" }
|
|
XCTAssertEqual(response?.accepted, false)
|
|
}
|
|
}
|