cdricms/vnidrop
1
1
Fork 0
mirror of https://github.com/sudosylabs/vnidrop.git synced 2026-08-05 02:29:55 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(apple): treat a completed receiver event as terminal

Browse Source 
progressForReceiver only labelled a receiver Completed when no progress/started
events preceded the completion, so the normal progress→completed sequence fell
through and rendered as Sending despite a .completed kind. Events are newest-first,
so a completed latest event is always terminal — label it Completed. Fixes the
failing ProgressDerivationTests.testReceiverCompletionAfterProgressIsTerminal.
This commit is contained in:
Cédric
2026-07-24 16:02:06 +02:00
parent 065d57e896
commit aab5f243ca
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apple/VniDrop/Core/TransferProgress.swift
View File

@@ -82,7 +82,9 @@ func progressForReceiver(
labelKey: L10n.Progress.interrupted, progress: nil, detail: nil labelKey: L10n.Progress.interrupted, progress: nil, detail: nil
) )
} }
if latestKind == .completed && !transferEvents.contains(where: { $0.eventKind == .progress || $0.eventKind == .started }) { // Events are newest-first, so a completed latest event is terminal even when
// progress/started events precede it — it must show as Completed, not Sending.
if latestKind == .completed {
return TransferProgress( return TransferProgress(
transferId: transferId, phase: .transfer, kind: .completed, transferId: transferId, phase: .transfer, kind: .completed,
labelKey: L10n.Progress.completed, progress: 1, detail: nil labelKey: L10n.Progress.completed, progress: 1, detail: nil