From 9b15a388d8cad6250dcb6be39e4df43787bc844c Mon Sep 17 00:00:00 2001 From: cdricms <36056008+cdricms@users.noreply.github.com> Date: Fri, 24 Jul 2026 17:54:59 +0200 Subject: [PATCH] fix(apple): polish the merged Network settings Move the relay-mode picker's Network title into a Section header (the inline picker label rendered as a stray row on iOS) and hide the picker label. Use a verbatim prompt for the relay URL placeholder so macOS stops markdown-linkifying the URL-shaped text into a purple link. --- .../Features/Settings/SettingsSections.swift | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/apple/VniDrop/Features/Settings/SettingsSections.swift b/apple/VniDrop/Features/Settings/SettingsSections.swift index 5a9696d..0e8605a 100644 --- a/apple/VniDrop/Features/Settings/SettingsSections.swift +++ b/apple/VniDrop/Features/Settings/SettingsSections.swift @@ -80,7 +80,7 @@ struct NetworkSettings: View { var body: some View { Section { Picker( - String(localized: "settings_network_title"), + "", selection: Binding(get: { model.state.relayMode }, set: { model.setRelayMode($0) }) ) { ForEach(RelayPreferenceMode.allCases, id: \.self) { mode in @@ -88,7 +88,10 @@ struct NetworkSettings: View { } } .pickerStyle(.inline) + .labelsHidden() .disabled(model.state.isApplyingRelayConfiguration) + } header: { + Text(String(localized: L10n.Settings.networkTitle)) } footer: { Text(LocalizedStringKey(relayModeDescriptionKey(model.state.relayMode))) } @@ -127,7 +130,7 @@ struct NetworkSettings: View { VStack(alignment: .leading, spacing: 6) { HStack { TextField( - "https://relay.example.com", + "", text: Binding( get: { model.state.relayURLs.indices.contains(index) @@ -135,8 +138,12 @@ struct NetworkSettings: View { : "" }, set: { model.setRelayURL($0, at: index) } - ) + ), + // `Text(verbatim:)` avoids macOS markdown-linkifying the + // URL-shaped placeholder into a purple link. + prompt: Text(verbatim: "https://relay.example.com") ) + .labelsHidden() #if os(iOS) .keyboardType(.URL) .textInputAutocapitalization(.never)